Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update snapshots #1165

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

chore: update snapshots #1165

wants to merge 2 commits into from

Conversation

jadutter
Copy link
Contributor

Description

Screenshots

Testing instructions

@jadutter jadutter added the snapshots Trigger new snapshots to be generated label Dec 13, 2024
jadutter
jadutter commented Dec 18, 2024
View reviewed changes
Copy link
Contributor Author

@jadutter jadutter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadutter jadutter mentioned this pull request Dec 20, 2024
Open
@jadutter
Copy link
Contributor Author

These snapshots appear to have been updated with ubuntu 22.
We will want to make sure they are using ubuntu 24 when they update.
See this comment for further details.

We may need to either

  • wait for GitHub to finish their rollout by Jan 17th
  • temporarily set our workflows to explicitly use ubuntu 24 instead of latest

@jadutter jadutter added snapshots Trigger new snapshots to be generated and removed snapshots Trigger new snapshots to be generated labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajha17 tajha17 tajha17 approved these changes

Assignees
No one assigned
Labels
snapshots Trigger new snapshots to be generated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jadutter @tajha17