Skip to content

Commit

Permalink
Locked in release for DO spec.
Browse files Browse the repository at this point in the history
stupid thing is throwing 404’s today for the latest release. Screw it, lock it down!
  • Loading branch information
daveshanley committed Sep 9, 2024
1 parent b175c90 commit e6a9a31
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions datamodel/high/base/licence_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ func TestLicense_Render_Identifier(t *testing.T) {

func TestLicense_Render_IdentifierAndURL_Error(t *testing.T) {

// this should fail because you can't have both an identifier and a URL
// this used to fail because you can't have both an identifier and a URL
// however in v0.18.0 I deleted this logic, because it's dumb.
highL := &License{Name: "MIT", Identifier: "MIT", URL: "https://pb33f.io"}
dat, _ := highL.Render()

Expand All @@ -95,5 +96,5 @@ func TestLicense_Render_IdentifierAndURL_Error(t *testing.T) {
_ = lowmodel.BuildModel(cNode.Content[0], &lowLicense)
err := lowLicense.Build(context.Background(), nil, cNode.Content[0], nil)

assert.Error(t, err)
assert.NoError(t, err)
}
4 changes: 3 additions & 1 deletion document_examples_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ func ExampleNewDocument_fromWithDocumentConfigurationSuccess() {
digitalOcean, _ := os.ReadFile("test_specs/digitalocean.yaml")

// Digital Ocean needs a baseURL to be set, so we can resolve relative references.
baseURL, _ := url.Parse("https://raw.githubusercontent.com/digitalocean/openapi/main/specification")
//baseURL, _ := url.Parse("https://raw.githubusercontent.com/digitalocean/openapi/main/specification")
// locked this in to a release, because the spec is throwing 404's occasionally.
baseURL, _ := url.Parse("https://raw.githubusercontent.com/digitalocean/openapi/9b763029ba805c3e0e56927fd6685d73bc27f3e8/specification")

// create a DocumentConfiguration that allows loading file and remote references, and sets the baseURL
// to somewhere that can resolve the relative references.
Expand Down

0 comments on commit e6a9a31

Please sign in to comment.