Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nil pointer check added to prevent panic. #131

Merged
merged 1 commit into from
Jun 21, 2023
Merged

nil pointer check added to prevent panic. #131

merged 1 commit into from
Jun 21, 2023

Conversation

daveshanley
Copy link
Member

When building docs from scratch, a slice not backed by a low-level model could throw an NPE, which is now fixed.

non-breaking change.

When building docs from scratch, a slice that is not backed by a low level model could throw a NPE, now fixed.

non breaking change.

Signed-off-by: Dave Shanley <dave@quobix.com>
@daveshanley daveshanley marked this pull request as ready for review June 21, 2023 12:59
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a4b7a01) 99.77% compared to head (3866d24) 99.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files         146      146           
  Lines       10174    10174           
=======================================
  Hits        10151    10151           
  Misses         23       23           
Flag Coverage Δ
unittests 99.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamodel/high/node_builder.go 98.77% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daveshanley daveshanley merged commit f790174 into main Jun 21, 2023
@daveshanley daveshanley deleted the v0.9.1 branch June 21, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant