Fixed high-level model handling of unevaluatedProperties #145
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unevaluatedProperties` was not being handled correctly by the high-level v3 schema. When being rendered down for validation, the correct type on the dynamic value was not being set correctly. This has been resolved without any change in coverage or needing new tests. Signed-off-by: Dave Shanley <dave@quobix.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 146 146
Lines 10349 10349
=======================================
Hits 10328 10328
Misses 21 21
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unevaluatedPropertieswas not being handled correctly by the high-level v3 schema. When being rendered down for validation, the correct type on the dynamic value was not being set correctly. This has been resolved without any change in coverage or needing new tests.