Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: introduce extension change detection for info section #185

Merged

Conversation

sebkunz
Copy link
Contributor

@sebkunz sebkunz commented Oct 13, 2023

This commit provides a fix for issue #184

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4dc693a) 99.75% compared to head (d5bfa3b) 99.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         149      149           
  Lines       10822    10827    +5     
=======================================
+ Hits        10796    10801    +5     
  Misses         26       26           
Flag Coverage Δ
unittests 99.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
what-changed/model/info.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebkunz
Copy link
Contributor Author

sebkunz commented Oct 13, 2023

LGTM!

Happy to see all checks have passed 👍 feel free to merge the PR and close the issue if you are happy with the changes and do not need any additional adjustment of the PR from my side. Looking forward to see the extension change detection for info extensions in an upcoming release!

@daveshanley
Copy link
Member

I am working on a significant update to the library with a rebuild of how the index works, I will include this update with that.

@daveshanley daveshanley merged commit 76dc865 into pb33f:main Nov 4, 2023
3 checks passed
@sebkunz sebkunz deleted the fix/info_extensions_change_detection branch February 22, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants