-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.15.16 #274
v0.15.16 #274
Conversation
Regression undone
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 162 162
Lines 12071 12077 +6
=======================================
+ Hits 12026 12032 +6
Misses 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Error was not being returned when rendering JSON
For reference, the missing line is actually covered by the test as it executes, for some reason the coverage tool is not picking it up, but the code does run, it's what caused a regression in the first place. lesson: only place to much trust in tooling. |
Addresses issues: