Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed MediaType example being populated from wrong source #276

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

TristanSpeakEasy
Copy link
Contributor

@daveshanley this fixes an issue where the MediaType.Example field was being populated when it shouldn't.

It was basically searching down into the schema and other places as well to find an example where it should have only been searching the top level node

@daveshanley
Copy link
Member

Cool! for some reason codecov has stopped working, trying to shake it loose.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (18a817b) to head (e33b13a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   99.61%   99.62%           
=======================================
  Files         162      162           
  Lines       12085    12085           
=======================================
+ Hits        12039    12040    +1     
+ Misses         46       45    -1     
Flag Coverage Δ
unittests 99.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley
Copy link
Member

Looks good! thank you for fixing.

@daveshanley daveshanley merged commit 6f277db into pb33f:main Apr 22, 2024
4 checks passed
@TristanSpeakEasy TristanSpeakEasy deleted the fix-request-body-examples branch April 23, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants