Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.16.9 #300

Merged
merged 17 commits into from
Jul 8, 2024
Merged

v0.16.9 #300

merged 17 commits into from
Jul 8, 2024

Conversation

daveshanley
Copy link
Member

@daveshanley daveshanley commented Jun 6, 2024

Adds GetKeyNode and GetRootNode methods to low level models. Useful for interfaces in downstream applications.
A general tuneup in various places after hammering the library as part of a larger stack of applications.

Addresses issues:

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 98.71795% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.63%. Comparing base (f27d57a) to head (9a7564d).

Files Patch % Lines
datamodel/high/node_builder.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   99.59%   99.63%   +0.04%     
==========================================
  Files         162      162              
  Lines       16103    16295     +192     
==========================================
+ Hits        16037    16236     +199     
+ Misses         61       54       -7     
  Partials        5        5              
Flag Coverage Δ
unittests 99.63% <98.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley
Copy link
Member Author

I cannot bump the coverage in the node builder. Overall overage is lifted by 0.06%

@daveshanley daveshanley merged commit 721e869 into main Jul 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant