WIP: 0.19.0 #359
Merged
WIP: 0.19.0 #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
========================================
Coverage 99.61% 99.62%
========================================
Files 165 165
Lines 21145 21537 +392
========================================
+ Hits 21064 21456 +392
Misses 76 76
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
useful for hashing nodes consistently.
not an exhaustive list, but covers a decent footprint.
This is not technically allowed according to the spec, however it’s super common. It’s also confusing the doctor when rendering the graph. Refs cannot be rendered in a tree, however it was doing so previously.
`StorageRoot` is not a part of the OpenAPI schema. It has no effect on resolving, or the rolodex. It is used by the OpenAPI doctor to determine where a document should live, when it’s a part of a larger network. It may be used by tool developers for their own purpose if required, but it has no effect on the model.
`SkipDocumentCheck` is now honors when looking up a component.
Was throwing race condition issues, locks now prevent this from happening, Also fixed the JSON `camelCase` from `snake_case`.
I should always assume that everything, can always be a nil pointer. Always.
now, if the document cannot be parsed, and we have enabled a bypass, then we still pack up the content into a YAML node and return it. This allows non YAML/JSON content to be collected by the rolodex, required for things like markdown, or source code.
`ReferenceMapped` can now be renredered and will do so using custom marshaling code. tags have been added also, but are ignored when marshaling. Also added a nodeMapLock to the index model.
Ensure that a schema cannot be rendered if it has a circular reference. Regardless of the type. This is a hard no for rendering inline.
Required to pull in references that are not JSON or YAML docs, like code samples or markdown.
Allows more effective lookups to be added. Also roll back the keyNode when performing a lookup.
I realized that `FindNodeOrigin` was insufficient when locating nodes at the start of fragments that are all identical. There is no way to determine if two files that both start with ‘post’ at 1:1 are the same or not, without also hashing the value. That is what this method does, using a hashing mechanism that runs as fast as possible.
Depending on how the rolodex has been used, it may miss circular references attached to index resolvers. Now this method will bubble up those results.
More tests!
And a document node check as well, so we keep things consistent.
Deals with issue #251 and daveshanley/vacuum#502
Looks like this code is finally ready and stable.
when being used remotely, things were still spinning out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a ton of changes, without breaking anything! There are no know breaking changes in this release, a lot of changes but nothing will break by upgrading.
Lots of updates to fix glitches and improve support for non OpenAPI files in the rolodex.