Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setext headings #206

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix setext headings #206

merged 1 commit into from
Jul 31, 2024

Conversation

Waqar144
Copy link
Contributor

did not test extensively, probably there are better ways to fix this.

@pbek
Copy link
Owner

pbek commented Jul 31, 2024

Looking great, thank you very much!

There's just a little problem with Qt 5.9 builds at https://github.com/pbek/qmarkdowntextedit/actions/runs/10176319084/job/28145421388?pr=206.

@pbek pbek merged commit 9af9c41 into pbek:develop Jul 31, 2024
22 checks passed
@pbek
Copy link
Owner

pbek commented Jul 31, 2024

Thank you very much!

pbek added a commit that referenced this pull request Aug 5, 2024
Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>
@pbek
Copy link
Owner

pbek commented Aug 6, 2024

@Waqar144, btw. this is what I did do fix highlighting for Qt 5.15.2: 48d602b

According to the documentation, Qt 5.15.1 should have been ok, but it seems there were issues that were later resolved...
In Qt6 QStringView::.mid even is deprecated now. 🤔

@pbek
Copy link
Owner

pbek commented Sep 9, 2024

This is causing new problems, see pbek/QOwnNotes#3101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants