Update QMarkdownTextEdit::handleBracketClosing to fix #207
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waqar144
reviewed
Aug 3, 2024
qmarkdowntextedit.cpp
Outdated
| @@ -717,7 +717,7 @@ bool QMarkdownTextEdit::handleBracketClosing(const QChar openingCharacter, | |||
| // Remove whitespace at start of string (e.g. in multilevel-lists). | |||
| const QString text = cursor.block().text().remove(QRegularExpression("^\\s+")); | |||
|
|
|||
| const int pib = cursor.positionInBlock(); | |||
| const int pib = cursor.positionInBlock() - cursor.block().text().length() + text.length(); | |||
There was a problem hiding this comment.
good one.
Would suggest using extra () parens to make the addition/subtraction order clear
Add brackets to subtract the length of leading spaces;
Waqar144
approved these changes
Aug 4, 2024
|
Hi @Waqar144 @pbek, sorry but it is okay if you can revert the merge? I just found a issue after my commits with line 723 qmarkdowntextedit/qmarkdowntextedit.cpp Line 723 in a06cfb1 pib could be negative and will cause issue QString indexing.
I will test more and come back to you later next week for this PR, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted index calculation in line 720 to include removed white-space;