Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unneeded LoC #124

Open
pbiggar opened this issue Jun 3, 2015 · 2 comments
Open

unneeded LoC #124

pbiggar opened this issue Jun 3, 2015 · 2 comments

Comments

@pbiggar
Copy link
Owner

pbiggar commented Jun 3, 2015

Hi,
in the dataflow branch, file optimize/Prune_symbol_table.cpp
in line 130 the assignement is unnecessary because you pass in the vars
already as argument to the Analysis constructor. Just having one way of
getting vars ought to be enough i think.

Original issue reported on code.google.com by c.r1@gmx.de on 2009-10-17 13:40:57

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

Seems right. Have you tested the change?

Original issue reported on code.google.com by paul.biggar on 2009-10-17 20:12:56

@pbiggar
Copy link
Owner Author

pbiggar commented Jun 3, 2015

I gotta say I fear this. My personal alias analysis is not very good, but this change
triggers a warning. It would need to be tested before doing this...

Original issue reported on code.google.com by paul.biggar on 2010-09-22 05:02:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant