Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulator builds by adding +nightly #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

garethknowles
Copy link

@garethknowles garethknowles commented Apr 2, 2024

Adding +nightly to simulator builds seems to fix pd-rs/crank/issues/57

@boozook
Copy link
Member

boozook commented Apr 15, 2024

Thanks! 👍
But what if user hasn't rustup, but just nightly toolchain?
This for example.

@paulyoung
Copy link

I don’t use rustup and adding +nightly causes errors for me.

It would be great if this could do something like check for the presence of rustup or be configured via an environment variable.

@boozook
Copy link
Member

boozook commented Apr 16, 2024

Rustup existence can be determined by env var, yes. Example.

@boozook
Copy link
Member

boozook commented Aug 10, 2024

Maybe just call crank so cargo +nightly crank? I'm not sure now, but if there cargo executable determined by CARGO env, it could fix this. 🤷🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulator builds fail due to use of stable release channel
3 participants