Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace heapless with the much smaller arrayvec #70

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

parasyte
Copy link
Contributor

@parasyte parasyte commented Oct 2, 2023

heapless has surprisingly a lot of dependencies, and the only thing it is used for is a stack-allocated string in the panic handler. None of these dependencies are needed.

├── crankstart v0.1.2
│   ├── anyhow v1.0.75
│   ├── crankstart-sys v0.1.2
│   ├── cstr_core v0.1.2
│   │   ├── cty v0.1.5
│   │   └── memchr v2.6.3
│   ├── euclid v0.22.9 (*)
│   ├── hashbrown v0.14.0 (*)
│   └── heapless v0.6.1
│       ├── as-slice v0.1.5
│       │   ├── generic-array v0.12.4
│       │   │   └── typenum v1.16.0
│       │   ├── generic-array v0.13.3
│       │   │   └── typenum v1.16.0
│       │   ├── generic-array v0.14.7
│       │   │   └── typenum v1.16.0
│       │   └── stable_deref_trait v1.2.0
│       ├── generic-array v0.14.7 (*)
│       ├── hash32 v0.1.1
│       │   └── byteorder v1.4.3
│       └── stable_deref_trait v1.2.0

After replacing it with arrayvec:

├── crankstart v0.1.2
│   ├── anyhow v1.0.75
│   ├── arrayvec v0.7.4
│   ├── crankstart-sys v0.1.2
│   ├── cstr_core v0.1.2
│   │   ├── cty v0.1.5
│   │   └── memchr v2.6.3
│   ├── euclid v0.22.9 (*)
│   └── hashbrown v0.14.0 (*)

Much better!

@boozook
Copy link
Member

boozook commented Oct 2, 2023

Good point!
I'll just test it and merge soon.
Thank you!

@boozook boozook merged commit 5b289e5 into pd-rs:main Oct 2, 2023
1 check passed
@parasyte parasyte deleted the replace/heapless branch October 2, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants