Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field for comments into state_stree #27

Closed
pddshk opened this issue Jun 6, 2023 · 0 comments · Fixed by #44
Closed

Add field for comments into state_stree #27

pddshk opened this issue Jun 6, 2023 · 0 comments · Fixed by #44
Assignees
@Blooddin @SmekhMaksimgithub
Labels
backend This issue is about backend feature New feature or request notation This issue is about notation

Comments

@pddshk
Copy link
Owner

pddshk commented Jun 6, 2023 •
edited
Loading

According to PGN file format movetext could contain comments in specific form. To achieve correspondence between PGN and internal game_info structure (would be added in #28 )

  • Add comment field (of type char* with default NULL value) to struct tnode.
  • Add memory management logic for comments (would be clarified later)
@pddshk pddshk added this to Canban Jun 6, 2023
@pddshk pddshk converted this from a draft issue Jun 6, 2023
@pddshk pddshk added feature New feature or request notation This issue is about notation backend This issue is about backend labels Jun 6, 2023
@pddshk pddshk moved this from Backlog to ToDo in Canban Jul 3, 2023
SmekhMaksimgithub added a commit that referenced this issue Jul 15, 2023
@SmekhMaksimgithub
Add comment field to tnode struct #27
cedf47d
SmekhMaksimgithub added a commit that referenced this issue Jul 16, 2023
@SmekhMaksimgithub
Add comment field setter (Fix #27)
0455ba3
@pddshk pddshk linked a pull request Aug 4, 2023 that will close this issue
Add field for comments state tree #44
Merged
@pddshk pddshk closed this as completed in #44 Aug 4, 2023
@github-project-automation github-project-automation bot moved this from ToDo to Done in Canban Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Blooddin Blooddin

@SmekhMaksimgithub SmekhMaksimgithub

Labels
backend This issue is about backend feature New feature or request notation This issue is about notation
Projects
Canban
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add field for comments state tree pddshk/GTK-Chess
3 participants
@pddshk @Blooddin @SmekhMaksimgithub