fix font height() and advance-width() scaled metrics

pdf-raku · Dec 16, 2023 · 181d2cf · 181d2cf
1 parent 2782838
commit 181d2cf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/Changes b/Changes
@@ -1,4 +1,6 @@
 {{$NEXT}}
+    - Fix face height and advance-width. Thanks Tom Browder
+    - Add face bbox() alias for bounding-box() #23.
 
 0.5.3  2023-08-10T06:26:27+12:00
     - Implement face .attach-file method and face creation option

diff --git a/lib/Font/FreeType/SizeMetrics.rakumod b/lib/Font/FreeType/SizeMetrics.rakumod
@@ -42,7 +42,7 @@ method descender {
 }
 
 method height {
-    $!raw.height * $.y-scale;
+    $!raw.height / Dot6;
 }
 
 method underline-position {
@@ -54,7 +54,7 @@ method underline-thickness {
 }
 
 method max-advance-width is also<max-advance> {
-    $!raw.max-advance * $.x-scale;
+    $!raw.max-advance / Dot6;
 }
 
 method max-advance-height {

diff --git a/t/10metrics_verasans.t b/t/10metrics_verasans.t
@@ -81,8 +81,8 @@ sub scaled-metrics-tests($scaled-metrics) {
     is $scaled-metrics.y-ppem, 12, '.y-ppem';
     is-approx $scaled-metrics.ascender, 11.138672, '.ascender';
     is-approx $scaled-metrics.descender, -2.830078, '.descender';
-    is $scaled-metrics.height, 5.25, '.height';
-    is $scaled-metrics.max-advance, 6.0, '.max-advance';
+    is $scaled-metrics.height, 14, '.height';
+    is $scaled-metrics.max-advance, 16, '.max-advance';
     is-approx $scaled-metrics.underline-position, -1.664063, '.underline-position';
     is-approx $scaled-metrics.underline-thickness, 0.837891, '.underline-thickness';
     my @bbox := $scaled-metrics.bounding-box;