-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deisa plugin #473
base: main
Are you sure you want to change the base?
Add deisa plugin #473
Conversation
* update embedded pybind11 to 2.11.1 to fix recent python version problems
For the sake of merging this feature quickly, I will open a new issue for the tests. |
update copyright and required cmake version Co-authored-by: Julien Bigot <jbigot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few propositions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few remaining very minor remarks
Co-authored-by: Julien Bigot <jbigot@users.noreply.github.com>
Co-authored-by: Julien Bigot <jbigot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the last batch of comments. This ended up being a much bigger cleanup than I anticipated, but I believe this will be good in the long term
Co-authored-by: Julien Bigot <jbigot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed a point. But apart from these 3 small changes that I forgot, I'd say it's good to ship.
Great cleanup work, I really believe the plugin is now in a much better situation and I'm now confident for its future!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, we're there now 🎉
Short description of the MR
Add Deisa plugin to enable in-situ analysis.
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format
;Fix #issue
keyword to autoclose the issue when merged.