Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup coding standard #148

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Cleanup coding standard #148

wants to merge 5 commits into from

Conversation

Potherca
Copy link
Member

@Potherca Potherca commented Jan 19, 2024

This MR:

  • Adds nextcloud/coding-standard as a development dependency
  • Updates the existing PHP Codesniffer config to match the Nextcloud Coding Standard
  • Fixes all PHP Codesniffer Violations

To review these changes, it is advised to toggle the "Ignore whitespace" setting, as the majority of the "fixes" are spaces ➡️ tabs. The few non-whitespace fixes are removing unused namespaces, and/or sorting the namespace in alphabetical order.

This MR has been marked as WIP because:

  • Development documentation needs to be added
  • The PHP code changes (and repercussions of those changes for existing developers/repos) need to be discussed/approved by existing @pdsinterop/main-team members.

@Potherca Potherca self-assigned this Jan 19, 2024
@Potherca Potherca added this to the v0.8.2 milestone Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant