Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some "usability" fixes #222

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Some "usability" fixes #222

merged 3 commits into from
Aug 23, 2023

Conversation

trevilo
Copy link
Contributor

@trevilo trevilo commented Aug 23, 2023

This PR collects 3 fixes for issues that were noticed while working on the cycle-averaged solver:

  1. There was a typo in the axisymmetric option (the code was reading asymmetric instead).
  2. As part of 1499f9a, the restart file write was erroneously eliminated from M2ulPhyS::solveStep
  3. After PR Allow the TPS driver to handle the time stepping #217, the cycle averaged solver no longer printed timing info.

@trevilo
Spelling fix (asymmetric -> axisymmetric)
da3a112 
In options for cycle-averaged coupled solver.
@trevilo
Revert some changes to M2ulPhyS::solveStep from 1499f9a
7d988e7 
In particular, the restart file write was eliminated, meaning that the
restart file was only written at the end of a run, regardless of how
frequently the user requested it (via the flow/outputFreq input
option).  This commit returns the behavior to that prior to 1499f9a.
@trevilo
Add timing info print for cycle-averaged solver step
76e2af9
@trevilo trevilo added the bug Something isn't working label Aug 23, 2023
@trevilo trevilo self-assigned this Aug 23, 2023
@trevilo trevilo merged commit 76e2af9 into main Aug 23, 2023
10 checks passed
@trevilo trevilo deleted the fix-solveStep-refactor branch August 26, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@trevilo trevilo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trevilo