Low-Mach averaging #276
Closed
Low-Mach averaging #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
April 23, 2024 18:32
…ple check and use of a null pointer when no variance calc is specified for fields. Still an issue with multiple fields and a segfault on the d_mean assignment line in addSampleInternal
|
These are good changes, but I prefer not to lump them into a single PR. Going to close this and open separate PRs for the averaging extension and the quadrature options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooked up averaging for Lo-Mach path. Fix to rms calculations. A few other clean-ups. Multiple points in initializatiion all ranks were printing info only rank0_ should have been. Added missing numerical integration check in calorically perfect. Added an "over_integration_" option which uses pre-refactor integration orders. Defaults to off.