Update collision integral fits #299
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should always pass for a valid model, but they don't. See #298 for more explanation. Because of those problems, a number of regression tests will fail at this commit.
The original fits (in functions collision::argon::eAr11, collision::argon::eAr12 etc) cause problems in the third order electron thermal conductivity calculation. Specifically, although the fits aren't that bad, the resulting approximation of the quantity L11 * L22 - L12 * L12, (where L here corresponds the \Lambda in the usual notation) behaves very badly (e.g., it goes negative near 8000K). This bad behavior can cause the electron thermal conductivity to also behave badly. This commit updates the fits to eliminate this problem. Due to these changes, a number of regression tests fail at this commit. These will be fixed in subsequent commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the collision integral fits for the e-Ar collisions to fix the problems documented in #298 .