Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] : fix test_ci_cd.yml file #538 #572

Merged
merged 2 commits into from
Jan 8, 2024
Merged

[Fix] : fix test_ci_cd.yml file #538 #572

merged 2 commits into from
Jan 8, 2024

Conversation

wochae
Copy link
Collaborator

@wochae wochae commented Jan 8, 2024

변경 사항

풀 인스턴스기 때문에 돌아가는 데이터베이스 컨테이너를 삭제하는 로직을 제거 했습니다.
원래 백엔드 전용 클라우드에서 컨테이너를 전부 지우는 행위를 대체하는 방법을 강구해야 함.




테스트 결과

@wochae wochae self-assigned this Jan 8, 2024
@sinryuji
Copy link
Collaborator

sinryuji commented Jan 8, 2024

🎉 @Paul2021-R 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@wochae wochae closed this Jan 8, 2024
@wochae wochae requested review from sinryuji and removed request for Paul2021-R January 8, 2024 09:19
@wochae wochae reopened this Jan 8, 2024
Copy link
Contributor

@Paul2021-R Paul2021-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것 같은 경우 기존 도커를 지우려고 하니 전체 리스트를 지우는게 아니라, 특정 컨테이너 명을 넣으면 되지 않을까요?

Copy link
Contributor

@Paul2021-R Paul2021-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨펌~~~~

@wochae wochae removed the request for review from sinryuji January 8, 2024 09:24
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wochae wochae merged commit b0cbe9e into dev Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants