[Feat] showcase_delete,update #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 @sinryuji 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏 |
…to 598-showcase
sinryuji
approved these changes
Jan 20, 2024
| @@ -218,4 +218,17 @@ public ResponseEntity<Object> updateShowcase(Long showcaseId, ShowcaseUpdateDto | |||
| objectService.deleteObject(temp); | |||
| return new ResponseEntity<>(HttpStatus.OK); | |||
| } | |||
|
|
|||
| @Transactional | |||
| public ResponseEntity<Object> deleteShowcase(Long showcaseId, Authentication auth){ | |||
There was a problem hiding this comment.
Service단 함수에서 Authentication을 받아 User로 변환하는 것보다 컨트롤러에서 변환 후 User를 건네주는게 더 좋을 것 같습니다. Authentication을 파라미터로 받는다 함은 무조건 컨트롤러에 종속되는 함수가 될 수 밖에 없고 재사용성이 너무 떨어지는 것 같아요.
There was a problem hiding this comment.
넵! 이해했습니다^^ 반영해서 수정하겠습니다~
| @@ -201,4 +203,32 @@ public Long createShowcase(ShowcaseCreateDto request, Authentication auth){ | |||
| post.addFile(objectService.uploadObject(filePath, request.getImage(), "image")); | |||
| return post.getId(); | |||
| } | |||
|
|
|||
| @Transactional | |||
| public ResponseEntity<Object> updateShowcase(Long showcaseId, ShowcaseUpdateDto request, Authentication auth){ | |||
There was a problem hiding this comment.
마찬가지로 Authentication을 미리 유저로 변환후 넘기는게 재사용성 측면에서 좋을 것 같아요. 같은 맥락으로 저는 Dto를 통째로 넘기는 것도 선호하지 않는 편인데 이 정도까지는 개취의 영역이라 생각합니다.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 사항
showcase의 delete, update api 구현
답글 api는 post 답글 api 활용
테스트 결과