Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] add-authorId-to-PostCommentListResponse #857

Merged

Conversation

weejihye
Copy link
Contributor

@weejihye weejihye commented Feb 13, 2024

변경 사항

게시물 댓글 조회시 authorId 필드를 추가합니다.
존재하지 않는 유저의 경우 authorId는 -1을 반환합니다.

시간이 없어 간단하게 추가할 수 있는 방식으로 작업되었습니다.
추후 hyeongki님이 작업하신 어노테이션으로 유저 유효성 검사가 수정될 필요가 있습니다.




테스트 결과

@weejihye weejihye self-assigned this Feb 13, 2024
@sinryuji
Copy link
Collaborator

🎉 @wochae 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@sinryuji sinryuji requested a review from wochae February 13, 2024 11:12
Copy link

sonarcloud bot commented Feb 13, 2024

Copy link
Collaborator

@wochae wochae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

존재하지 않는 작성자 -1 처리
확인했습니다!

@weejihye weejihye merged commit 32d6331 into release-1.0.3 Feb 13, 2024
4 checks passed
@weejihye weejihye deleted the hotfix-add-authorId-to-PostCommentListResponse branch February 14, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants