Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.6 / H-SC] 쇼케이스 대공사 #1044

Merged
merged 3 commits into from
Mar 3, 2024
Merged

[1.0.6 / H-SC] 쇼케이스 대공사 #1044

merged 3 commits into from
Mar 3, 2024

Conversation

HiHoi
Copy link
Contributor

@HiHoi HiHoi commented Feb 15, 2024 •
edited
Loading

변경사항

  1. 휴대폰 목업 변경
image
  1. 이미지 404에 대한 대처
image
  1. 태블릿 뷰 대응
image
  1. 모바일 화면에서 하단 버튼 추가
image
  1. 좋아요와 관심 추가 버그 수정
  2. 긴 내용이 들어올 때의 대응 (Thanks to Hyna)

@HiHoi HiHoi self-assigned this Feb 15, 2024
@HiHoi HiHoi requested a review from a team as a code owner February 15, 2024 06:29
@HiHoi HiHoi requested review from KRimwoo and joonseong11 and removed request for a team February 15, 2024 06:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues

Measures
0 Security Hotspots
No data about Coverage
16.5% Duplication on New Code

See analysis details on SonarCloud

joonseong11
joonseong11 approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@joonseong11 joonseong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨어요 굿굿

src/app/showcase/panel/CardContainer.style.ts
@@ -1,4 +1,10 @@
import { SxProps } from '@mui/material'
import { Inter } from 'next/font/google'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google 폰트를 사용하신거군요?

@HiHoi HiHoi added this pull request to the merge queue Mar 3, 2024
Merged via the queue into release-1.0.6 with commit fcdd294 Mar 3, 2024
3 checks passed
@yoouyeon yoouyeon deleted the 1.0.6/H-SC/1039 branch June 26, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonseong11 joonseong11 joonseong11 approved these changes

@KRimwoo KRimwoo Awaiting requested review from KRimwoo KRimwoo is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@HiHoi HiHoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiHoi @joonseong11