Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.6 / D-TP] 댓글 일자 표시 버그 수정 #1072

Merged
merged 6 commits into from
Mar 3, 2024
Merged

[1.0.6 / D-TP] 댓글 일자 표시 버그 수정 #1072

merged 6 commits into from
Mar 3, 2024

Conversation

yoouyeon
Copy link
Contributor

관련 이슈

작업 내용

  • 댓글 일자 실시간으로 보이는 문제 -> 타입 오류로 undefined로 처리되어 현재 시간을 보여주는 문제였습니다. 타입 통일시켜서 문제 해결했습니다.
    Screen_Shot 2024-02-26 15 52 42
  • 게시판에서 처리되는 일자를 local time으로 변환하는 로직 추가

@yoouyeon yoouyeon added the bug Something isn't working label Feb 26, 2024
@yoouyeon yoouyeon self-assigned this Feb 26, 2024
@yoouyeon yoouyeon requested a review from a team as a code owner February 26, 2024 06:58
@yoouyeon yoouyeon requested review from HiHoi and hyeon81 and removed request for a team February 26, 2024 06:58
HiHoi
HiHoi previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@HiHoi HiHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yoouyeon yoouyeon requested a review from HiHoi March 3, 2024 13:39
HiHoi
HiHoi approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@HiHoi HiHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 찾은 버그네요 수고하셨습니다!

@yoouyeon yoouyeon added this pull request to the merge queue Mar 3, 2024
Merged via the queue into release-1.0.6 with commit 44e081f Mar 3, 2024
3 checks passed
@yoouyeon yoouyeon deleted the 1070-106-d-tp-comment-date-bug branch June 26, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiHoi HiHoi HiHoi approved these changes

@hyeon81 hyeon81 Awaiting requested review from hyeon81 hyeon81 is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@yoouyeon yoouyeon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoouyeon @HiHoi