Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.6] ABOUT 페이지의 Contact us의 max length가 적다는 피드백 #1086

Merged
merged 1 commit into from
Mar 3, 2024
Merged

[1.0.6] ABOUT 페이지의 Contact us의 max length가 적다는 피드백 #1086

merged 1 commit into from
Mar 3, 2024

Conversation

HiHoi
Copy link
Contributor

@HiHoi HiHoi commented Feb 29, 2024

바뀐점

  • 기존 300자 였던 최대 길이를 이미지를 고려해서 1000자로 늘렸습니다.
  • API 저장소에 Validation이 기재가 안된 점을 체크하고 추가했습니다.

@HiHoi HiHoi added the bug Something isn't working label Feb 29, 2024
@HiHoi HiHoi self-assigned this Feb 29, 2024
@HiHoi HiHoi requested a review from a team as a code owner February 29, 2024 09:43
@HiHoi HiHoi requested review from asroq1 and joonseong11 and removed request for a team February 29, 2024 09:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

joonseong11
joonseong11 approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@joonseong11 joonseong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 버그픽스 좋아요~

@HiHoi HiHoi added this pull request to the merge queue Mar 3, 2024
Merged via the queue into release-1.0.6 with commit 4054818 Mar 3, 2024
3 checks passed
@yoouyeon yoouyeon deleted the 1.0.6/ABOUT/1064 branch June 26, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonseong11 joonseong11 joonseong11 approved these changes

@asroq1 asroq1 Awaiting requested review from asroq1 asroq1 is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@HiHoi HiHoi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiHoi @joonseong11