Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PUBLIC] Storybook 작업 #1100

Merged
merged 22 commits into from
Mar 21, 2024
Merged

[PUBLIC] Storybook 작업 #1100

merged 22 commits into from
Mar 21, 2024

Conversation

SaltySalt77
Copy link
Contributor

@SaltySalt77 SaltySalt77 commented Mar 8, 2024 •
edited
Loading

메모

초기작업이라 변경점이 많습니다. 그러나 대부분 스토리북 에셋 설치나, icon story 때문이므로 생각보다 리뷰할 양이 많지는 않습니다.

storybook에 올린 컴포넌트

  1. CuAvatar
  2. CuPhotoBox
  3. icons
    • .refresh_icon_story.sh를 추가하여, 아이콘이 추가되었을 때 번거롭지 않도록 처리하였습니다. 아이콘 추가 이후 해당 스크립트를 실행하면 알아서 스토리를 추가해줍니다.
    • AllIcons 컴포넌트를 추가하여 아이콘 목록을 한 번에 볼 수 있도록 처리하였습니다. 임시적 처리이므로 이후에 다시 삭제될 예정입니다.
  4. ControlledSelect, ControlledTextfield

SaltySalt77 and others added 20 commits March 5, 2024 12:46
Chore: Set storybook
61210b9
Refact: Refactored colorTheme for storybook
3b9ba81
Feat: Add CuAvatar to storybook
8364678
Chore: Add setting for mui to storybook
0ff7dd1
Chore: Settup directory
af22dbb
Chore: Add refresh icon story script
8c3b1bf
Chore: Refactored shell script for sub directories
d303fd1
@asroq1
update : LinkButton with new feat
21a8813
@asroq1
fix: getIcon has changed as a component
196e97c
@asroq1
feat : Add Comment editing feature in showcase-comment
0034d56
@asroq1
delete : dummy annotation
01b6dc0
@asroq1
fix : Separate error handler
d8796ff
Docs: Moved .refresh_icon_story.sh to root
9b12703
Docs: Renamed file extention to tsx
2296b55
Feat: Add AllIcons component for storybook
4c4b8f6
Docs: Removed unnecessary code
f6f2309
Docs: Add Controlled inputs to storybook
bfb36f7 
need to refactor and redesign them
Feat: Add Decorator for rhf
eb958da
Merge branch 'release-1.0.7' into 912-storybook
a50a48c
Fix: Resolved issue not showing image in storybook
0ebec8a
@SaltySalt77 SaltySalt77 self-assigned this Mar 8, 2024
@SaltySalt77 SaltySalt77 requested a review from a team as a code owner March 8, 2024 08:34
@SaltySalt77 SaltySalt77 requested review from yoouyeon and asroq1 and removed request for a team March 8, 2024 08:34
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

joonseong11
joonseong11 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@joonseong11 joonseong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ㅎㅎ

@joonseong11 joonseong11 merged commit d357997 into release-1.0.7 Mar 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonseong11 joonseong11 joonseong11 approved these changes

@yoouyeon yoouyeon Awaiting requested review from yoouyeon yoouyeon is a code owner automatically assigned from peer-42seoul/frontend

@asroq1 asroq1 Awaiting requested review from asroq1 asroq1 is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@SaltySalt77 SaltySalt77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaltySalt77 @joonseong11 @asroq1