Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.7 / ABOUT] footer의 적용을 위해 라우팅 방식 변겅 #1108

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[1.0.7 / ABOUT] footer의 적용을 위해 라우팅 방식 변겅 #1108

merged 1 commit into from
Mar 12, 2024

Conversation

HiHoi
Copy link
Contributor

@HiHoi HiHoi commented Mar 11, 2024

구현 사항

  • 기존 pararellal routing 방식의 about를 하나하나의 url로 나눴습니다.

@HiHoi HiHoi self-assigned this Mar 11, 2024
@HiHoi HiHoi requested a review from a team as a code owner March 11, 2024 10:08
@HiHoi HiHoi requested review from yoouyeon and asroq1 and removed request for a team March 11, 2024 10:08
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
4.1% Duplication on New Code

See analysis details on SonarCloud

asroq1
asroq1 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@asroq1 asroq1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!!

@asroq1 asroq1 merged commit 59b6215 into release-1.0.7 Mar 12, 2024
3 checks passed
@HiHoi HiHoi deleted the 1.0.7/ABOUT/1107 branch March 27, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asroq1 asroq1 asroq1 approved these changes

@yoouyeon yoouyeon Awaiting requested review from yoouyeon yoouyeon is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@HiHoi HiHoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiHoi @asroq1