Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-MAIN][J-TB] 메인페이지, 모집글 디테일 변경 (현재 명수 삭제, 카드 디자인) #1138

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

hyeon81
Copy link
Contributor

@hyeon81 hyeon81 commented Jul 18, 2024

image
image

  • 메인페이지 카드 디자인 변경 (날짜랑 명수 간격을 줄였고 스터디/프로젝트 여부도 넣었습니다)
  • 모집글 디테일의 현재 명수를 삭제했습니다

@hyeon81 hyeon81 changed the base branch from main to release-1.0.9 July 18, 2024 14:43
@hyeon81 hyeon81 changed the title Fix/recruit card [C-MAIN][J-TB] 메인페이지, 모집글 디테일 변경 (현재 명수 삭제, 카드 디자인) Jul 19, 2024
@hyeon81 hyeon81 marked this pull request as ready for review July 19, 2024 16:16
@hyeon81 hyeon81 requested a review from a team as a code owner July 19, 2024 16:16
@hyeon81 hyeon81 requested review from HiHoi and yoouyeon and removed request for a team July 19, 2024 16:16
@hyeon81 hyeon81 self-assigned this Jul 19, 2024
Copy link
Contributor

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다! 타입 에러 나는 부분만 다시 확인 부탁드립니다~ 수고하셨어용 👏👏👏

@@ -101,7 +101,6 @@ const MainPcView = ({ initData }: { initData: IPagination<IPost[]> }) => {
<Grid item key={project.recruit_id} sm={12} md={6} lg={4}>
<MainCard
{...project}
type={type}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MainCard 내에서 모집글 링크 만들 때 type을 사용하는 것 같아서 type은 계속 props로 넘겨줘야 할 것 같아요~
(지금은 타입에러가 나고 있네용 ㅎㅎ)
Screen_Shot 2024-07-20 14 33 30

@joonseong11 joonseong11 requested review from joonseong11 and removed request for HiHoi July 26, 2024 08:01
Copy link

sonarcloud bot commented Jul 29, 2024

@hyeon81 hyeon81 requested a review from yoouyeon July 29, 2024 05:36
Copy link
Contributor

@joonseong11 joonseong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어욤

@joonseong11 joonseong11 merged commit 8868c7b into release-1.0.9 Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants