[D-TP] 공지사항 위젯 #547
Merged
[D-TP] 공지사항 위젯 #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
asroq1
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
key={crypto.randomUUID()} key값에 인자는 왜 이렇게 넣어주시는 걸까요 ? 처음 보는 형태라 궁금해서 질문드립니다!
There was a problem hiding this comment.
소나클라우드에서 index를 map의 key 값으로 넣어주면 warning을 띄우더라구요. index 말고는 마땅히 key로 써줄 값이 없어서 내장객체 crypto의 randomUUID 메소드를 이용해서 랜덤한 key를 넣어준거예요! https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID
근데 리뷰 남겨주신 것 보고 다시 보니까 여기는 randomUUID를 쓰지 않고도 postId를 가지고 key를 부여할 수 있었네요.... 이거는 다음 PR에 수정해두겠습니다 🥲
There was a problem hiding this comment.
덕분에 이런 방식도 사용할 수 있는지 배웠네요! 감사합니다 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
공지사항 위젯을 추가했습니다.
공지사항 위젯 L / M
공지사항 미리보기
추가 작업 예정인 것들
관련 이슈