Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C-MAIN] 메인페이지 스터디/프로젝트 선택을 url 쿼리스트링에 저장 / 모집글 마감 시 지원버튼 텍스트 수정 #932

Merged
merged 5 commits into from
Feb 13, 2024
Merged

[C-MAIN] 메인페이지 스터디/프로젝트 선택을 url 쿼리스트링에 저장 / 모집글 마감 시 지원버튼 텍스트 수정 #932

merged 5 commits into from
Feb 13, 2024

Conversation

hyeon81
Copy link
Contributor

@hyeon81 hyeon81 commented Feb 12, 2024

image

image

  • 모집글의 인원이 모두 차거나 모집완료인 경우 지원하기 버튼에 '마감'이라는 텍스트가 띄워지도록 했습니다.

@hyeon81 hyeon81 self-assigned this Feb 12, 2024
@hyeon81 hyeon81 requested a review from a team as a code owner February 12, 2024 16:13
@hyeon81 hyeon81 changed the title [C-MAIN] 메인페이지 스터디/프로젝트 선택을 url 쿼리스트링에 저장 [C-MAIN] 메인페이지 스터디/프로젝트 선택을 url 쿼리스트링에 저장 / 모집글 마감 시 지원버튼 수정 Feb 12, 2024
@hyeon81 hyeon81 changed the title [C-MAIN] 메인페이지 스터디/프로젝트 선택을 url 쿼리스트링에 저장 / 모집글 마감 시 지원버튼 수정 [C-MAIN] 메인페이지 스터디/프로젝트 선택을 url 쿼리스트링에 저장 / 모집글 마감 시 지원버튼 텍스트 수정 Feb 12, 2024
@joonseong11
Copy link
Contributor

CI 실패했어요!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

HiHoi
HiHoi approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@HiHoi HiHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@hyeon81 hyeon81 merged commit aece636 into release-1.0.3 Feb 13, 2024
3 checks passed
@yoouyeon yoouyeon deleted the 1.0.3/C-MAIN/querystring-911 branch February 14, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiHoi HiHoi HiHoi approved these changes

@KRimwoo KRimwoo Awaiting requested review from KRimwoo KRimwoo is a code owner automatically assigned from peer-42seoul/frontend

@joonseong11 joonseong11 Awaiting requested review from joonseong11 joonseong11 is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@hyeon81 hyeon81

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyeon81 @joonseong11 @HiHoi