Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.3] 페이지 전환 효과 추가 #943

Merged
merged 4 commits into from
Feb 13, 2024
Merged

[1.0.3] 페이지 전환 효과 추가 #943

merged 4 commits into from
Feb 13, 2024

Conversation

KRimwoo
Copy link
Contributor

@KRimwoo KRimwoo commented Feb 13, 2024 •
edited
Loading

  • app 루트폴더에 template 추가하고 css로 스타일 추가 했습니다. 참고
  • my-page, team/[id], about 페이지에도 template을 추가하고 team-list는 layout의 children을 감싸고 있는 box에 template과 같은 효과를 주었습니다.
  • 추가로 textfield 높이나 정렬이 어긋나는 문제를 고치고 team/[id] 페이지의 레이아웃 버그를 수정했습니다.

resolves: #938 #954

@KRimwoo KRimwoo self-assigned this Feb 13, 2024
@KRimwoo KRimwoo requested a review from a team as a code owner February 13, 2024 08:50
@KRimwoo KRimwoo marked this pull request as draft February 13, 2024 09:01
@yoouyeon yoouyeon linked an issue Feb 13, 2024 that may be closed by this pull request
[1.0.3] 페이지 전환 효과 #938
Closed
1 task
joonseong11
joonseong11 previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@joonseong11 joonseong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런식으로 로드시 애니메이션 효과를 주는군요 잘 봤습니다 고생하셨어요 ㅎㅎ

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KRimwoo KRimwoo marked this pull request as ready for review February 13, 2024 16:33
SaltySalt77
SaltySalt77 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@SaltySalt77 SaltySalt77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

페이지 전환 효과를 넣으신 점 확인했습니다. 고생하셨습니다!

@KRimwoo KRimwoo merged commit 029e450 into release-1.0.3 Feb 13, 2024
3 checks passed
@yoouyeon yoouyeon deleted the feat/animate-route-transition branch February 14, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaltySalt77 SaltySalt77 SaltySalt77 approved these changes

@asroq1 asroq1 Awaiting requested review from asroq1 asroq1 is a code owner automatically assigned from peer-42seoul/frontend

@joonseong11 joonseong11 Awaiting requested review from joonseong11

@yoouyeon yoouyeon Awaiting requested review from yoouyeon

Assignees

@KRimwoo KRimwoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.0.3] 페이지 전환 효과
3 participants
@KRimwoo @joonseong11 @SaltySalt77