Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C-MAIN][J-TB][C-TB] 각종 디자인 수정, 에러 수정 #948

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[C-MAIN][J-TB][C-TB] 각종 디자인 수정, 에러 수정 #948

merged 1 commit into from
Feb 13, 2024

Conversation

hyeon81
Copy link
Contributor

@hyeon81 hyeon81 commented Feb 13, 2024

  1. [J-TB] 모집글 상태가 완료인데, 수정이 됨. #939
    image
  • 모집완료된 모집글일 경우 수정을 disabled 했습니다.

  1. 메인페이지의 경우 700px 이하 480px 이상 일때 옆의 메인프로필, 쇼케이스가 안보이도록 처리했습니다. (레이아웃 깨짐을 방지하기 위함)
    image

  2. 모집글 뷰의 이미지의 크기를 조정했습니다.
    image

  3. 알림과 pcNav의 레이아웃이 겹쳐서, pcNav의 css 요소를 수정했습니다.

기타... 자잘한 사항들을 수정했습니다.

@hyeon81 hyeon81 requested a review from a team as a code owner February 13, 2024 12:58
@hyeon81 hyeon81 self-assigned this Feb 13, 2024
@hyeon81 hyeon81 added enhancement New feature or request Design Design 얹을 때 사용합니다. labels Feb 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yoouyeon yoouyeon linked an issue Feb 13, 2024 that may be closed by this pull request
[J-TB] 모집글 상태가 완료인데, 수정이 됨. #939
Closed
SaltySalt77
SaltySalt77 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@SaltySalt77 SaltySalt77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 없는 것 같습니다. 고생하셨습니다!

@hyeon81 hyeon81 merged commit 3436f64 into release-1.0.3 Feb 13, 2024
3 checks passed
@yoouyeon yoouyeon deleted the 1.0.3/J-TB/editbutton branch February 14, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaltySalt77 SaltySalt77 SaltySalt77 approved these changes

@HiHoi HiHoi Awaiting requested review from HiHoi HiHoi is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@hyeon81 hyeon81

Labels
Design Design 얹을 때 사용합니다. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[J-TB] 모집글 상태가 완료인데, 수정이 됨.
2 participants
@hyeon81 @SaltySalt77