Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.3 / C-MYPAGE] 모바일 쪽지 삭제 버그 수정 #951

Merged
merged 2 commits into from
Feb 13, 2024
Merged

[1.0.3 / C-MYPAGE] 모바일 쪽지 삭제 버그 수정 #951

merged 2 commits into from
Feb 13, 2024

Conversation

yoouyeon
Copy link
Contributor

@yoouyeon yoouyeon commented Feb 13, 2024 •
edited
Loading

관련 이슈

작업 내용

Screen_Shot 2024-02-13 22 22 25
  1. 모바일에서 쪽지 삭제 안됨
    => 좋은 구조는 아니지만;; 모바일에서 삭제 api를 호출하는 부분이 pc와 다른데 이 부분에서는 api request body의 수정사항이 반영되지 않았던 것이 문제였습니다. body 수정해서 삭제 되는 것까지 확인했습니다.
  2. 삭제 버튼 너비 줄어듦
    => 원인은 모르겠는데 width 설정이 반영되지 않는 상황입니다. (테마에 min-width가 적용되어 있긴 한데 20px로 설정하려는 width 보다는 작은값입니다.) 일단은 삭제 버튼의 min-width, max-width를 모두 2.5rem으로 지정해서 문제를 해결해두었습니다 🥲

@yoouyeon yoouyeon added bug Something isn't working Design Design 얹을 때 사용합니다. labels Feb 13, 2024
@yoouyeon yoouyeon self-assigned this Feb 13, 2024
@yoouyeon yoouyeon requested a review from a team as a code owner February 13, 2024 13:31
@yoouyeon yoouyeon linked an issue Feb 13, 2024 that may be closed by this pull request
[1.0.3 / C-MYPAGE] 모바일 쪽지 삭제 버그 #946
Closed
2 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

joonseong11
joonseong11 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@joonseong11 joonseong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutate 를 활용하는 부분 배워가네요 잘 봤습니다 ㅎㅎ

@yoouyeon yoouyeon merged commit 8225749 into release-1.0.3 Feb 13, 2024
3 checks passed
@yoouyeon yoouyeon deleted the 946-103-c-mypage-mobile-message-delete-bug branch February 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonseong11 joonseong11 joonseong11 approved these changes

@HiHoi HiHoi Awaiting requested review from HiHoi HiHoi is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@yoouyeon yoouyeon

Labels
bug Something isn't working Design Design 얹을 때 사용합니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.0.3 / C-MYPAGE] 모바일 쪽지 삭제 버그
2 participants
@yoouyeon @joonseong11