Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.3 / C-MYPAGE] 쪽지 보내기 모달 InputBase수정 #996

Merged
merged 1 commit into from
Feb 14, 2024
Merged

[1.0.3 / C-MYPAGE] 쪽지 보내기 모달 InputBase수정 #996

merged 1 commit into from
Feb 14, 2024

Conversation

KRimwoo
Copy link
Contributor

@KRimwoo KRimwoo commented Feb 14, 2024 •
edited
Loading

  • 쪽지 모달의 InputBase를 TextField로 바꾸고 multiline을 적용했습니다.
  • 쪽지 내용 길이 제한 추가
  • 삭제된 채팅방 페이지에서 채팅방이 삭제되었다는 문구 추가
  • 기타 contained button 안의 typo가 라이트 모드에서 검정색으로 보이는 부분 수정
    resolves: [1.0.3 / C-MYPAGE] 쪽지보내기 모달 InputBase multiline설정 #993

@KRimwoo KRimwoo self-assigned this Feb 14, 2024
@KRimwoo KRimwoo requested a review from a team as a code owner February 14, 2024 06:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
32.1% Duplication on New Code (required ≤ 20%)

See analysis details on SonarCloud

HiHoi
HiHoi approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@HiHoi HiHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스타일 수정! 수고하셨습니다

@HiHoi HiHoi added this pull request to the merge queue Feb 14, 2024
Merged via the queue into release-1.0.3 with commit 0218592 Feb 14, 2024
2 of 3 checks passed
@HiHoi HiHoi deleted the fix/message-modal-textfield branch February 14, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiHoi HiHoi HiHoi approved these changes

@yoouyeon yoouyeon Awaiting requested review from yoouyeon yoouyeon is a code owner automatically assigned from peer-42seoul/frontend

@asroq1 asroq1 Awaiting requested review from asroq1 asroq1 is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@KRimwoo KRimwoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KRimwoo @HiHoi