Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExponentiationExpression rule to javascript.pegjs #446

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

frostburn
Copy link
Contributor

Implement exponentiation with right associativity i.e. x**y**z = x**(y**z).

@hildjj
Copy link
Contributor

hildjj commented Dec 3, 2023

LGTM. Are you in the AUTHORS file already? If not, please add yourself, and tack that on to this commit. Also, please make a CHANGELOG.md entry.

@frostburn
Copy link
Contributor Author

Done. There was no associated ticket as this came up spontaneously when adapting the example grammar.

@hildjj
Copy link
Contributor

hildjj commented Dec 3, 2023

Please use the PR# as the link for changes that don't have an associated issue.

Implement exponentiation with right associativity i.e. x**y**z = x**(y**z).
@frostburn
Copy link
Contributor Author

Gotcha. 👌 Fixed.

@hildjj hildjj merged commit 8aa207c into peggyjs:main Dec 3, 2023
9 checks passed
@frostburn frostburn deleted the js-exponentiation branch December 3, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants