Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developer docs. #469

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Add developer docs. #469

merged 2 commits into from
Feb 12, 2024

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Feb 11, 2024

Fixes #466.

@hildjj
Copy link
Contributor Author

hildjj commented Feb 11, 2024

@frostburn please review.

@frostburn
Copy link
Contributor

Looks good and got the project up and running on my end. 👍

Additional remarks

  1. It would be nice to link to CONTRIBUTING.md in README.md.
  2. After the setup described in this PR I got untracked files docs/package-lock.json and web-test/package-lock.json. These should be either included in the repository or added to .gitignore.
  3. It might've been npm run lint but docs/js/test-bundle.min.js ends up modified on my end according to git.

@hildjj
Copy link
Contributor Author

hildjj commented Feb 12, 2024

  1. willfix
  2. willfix, was playing with workspaces, but decided I didn't like them.
  3. I might not have checked in my last test fixes minified. willfix.

@hildjj hildjj merged commit d02bf1c into peggyjs:main Feb 12, 2024
9 checks passed
@hildjj hildjj deleted the fix-466 branch February 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document project setup
2 participants
@hildjj @frostburn