sparse histogram with cumulative counts with read-only strait #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brayniac
reviewed
Jul 8, 2024
| @@ -19,6 +19,114 @@ pub struct SparseHistogram { | |||
| pub count: Vec<u64>, | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, PartialEq)] | |||
| #[cfg_attr(feature = "serde-serialize", derive(Serialize, Deserialize))] | |||
| pub struct SparseHistogramRO { | |||
There was a problem hiding this comment.
Let's add a doc comment for the struct. It'd be nice to have something that explains what it is and when you might use it.
There was a problem hiding this comment.
I'm wondering if calling it an CumulativeSparseHistogram is clearer. I'm not sure I love the short suffix to indicate read-only. ImmutableSparseHistogram might be better if you want to keep the focus on that aspect instead of how it's implemented.
There was a problem hiding this comment.
I like CumulativeSparseHistogram, we can explain why it only supports the read methods in the doc comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.