rewrite of the histogram crate #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the histogram crate to merge heatmap functionality into this crate and reparameterize the histogram constructors.
mihirn
reviewed
Aug 25, 2023
Adds a few benchmarks and increases the minimum interval for the sliding window histograms. We can lower it in the future, but for now, increasing to milliseonds as finest resolution prevents excessive looping when snapshots are needed on increment.
Return build errors instead of panicing via assert if the sliding window interval is either too short or too long
mihirn
reviewed
Aug 30, 2023
brayniac
commented
Sep 13, 2023
brayniac
commented
Sep 13, 2023
brayniac
commented
Sep 14, 2023
mihirn
reviewed
Sep 14, 2023
mihirn
reviewed
Sep 14, 2023
mihirn
reviewed
Sep 15, 2023
mihirn
reviewed
Sep 18, 2023
mihirn
reviewed
Sep 18, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thinkingfish
approved these changes
Sep 26, 2023
| } | ||
|
|
||
| /// Produce a snapshot from this histogram. | ||
| pub fn snapshot(&self) -> Snapshot { |
There was a problem hiding this comment.
We might need another API where the snapshot is pre-allocated and provided by the caller so we can minimize allocation? Fine to add it in a different PR.
There was a problem hiding this comment.
snapshot_into() would be nice. Will do a follow-on PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the histogram crate to merge heatmap functionality into this crate and
reparameterize the histogram constructors.