Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(histogram): expose histogram add functions #85

Merged
merged 1 commit into from
Oct 23, 2023
Merged

feat(histogram): expose histogram add functions #85

merged 1 commit into from
Oct 23, 2023

Conversation

brayniac
Copy link
Contributor

Exposes the Histogram::checked_add and wrapping_add functions publicly.

@brayniac
feat(histogram): expose histogram add functions
d217015 
Exposes the `Histogram::checked_add` and `wrapping_add` functions
publicly.
@brayniac brayniac mentioned this pull request Oct 23, 2023
Closed
@brayniac brayniac enabled auto-merge (squash) October 23, 2023 17:22
@mihirn
Copy link
Contributor

mihirn commented Oct 23, 2023

Should we also do checked/wrapping_sub here?

@brayniac
Copy link
Contributor Author

Should we also do checked/wrapping_sub here?

I'm unclear on if there's a use case for the subtraction functions to be public. Do you have one in mind?

@brayniac brayniac merged commit 4520f25 into pelikan-io:main Oct 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihirn mihirn mihirn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brayniac @mihirn