Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text on BSP withdraw #598

Open
prayagd opened this issue Oct 16, 2024 · 7 comments
Open

Update text on BSP withdraw #598

prayagd opened this issue Oct 16, 2024 · 7 comments

Comments

@prayagd
Copy link
Collaborator

prayagd commented Oct 16, 2024

As a Forex AMM user, i should be able to see how much time i need to wait to withdraw from the BSP after supplying liquidity to the swap pool

Acceptance criteria

  • While withdrawing from the BSP pool, if 14 days of timelock are not completed. They see the message "You cannot redeem tokens from the backstop pool yet"
  • Update the message to "You can redeem tokens from the backstop pool in {time remaining to complete the timelock DD:HH}"
  • For simplicity ex. the user supplied liquidity 10 days ago, they should see the message "You can redeem tokens from the backstop pool in 4 days"

Notes

  • Timelocks are managed per pool and per account.

Reference

image

@prayagd
Copy link
Collaborator Author

prayagd commented Oct 16, 2024

Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz @TorstenStueber

@prayagd
Copy link
Collaborator Author

prayagd commented Oct 16, 2024

Let me know if anything unclear

@prayagd
Copy link
Collaborator Author

prayagd commented Oct 22, 2024

Reminder ping to add estimates

@TorstenStueber
Copy link
Member

How should we render the remaining time? If it is more than one day, then obviously the number of remaining days (rounded down?). If it less than a day, then the amount in hours? If it less than one hour, then amount in minutes, etc.?

@prayagd
Copy link
Collaborator Author

prayagd commented Nov 6, 2024

DD:HH

I would suggest we limit it to hours only, not minutes

@TorstenStueber
Copy link
Member

I am not familiar with the DD:HH format, as a user I would think that it would indicate HH:MM instead. Or do you mean something like "10 days and 8 hours"?

@prayagd
Copy link
Collaborator Author

prayagd commented Nov 6, 2024

Or do you mean something like "10 days and 8 hours"?

Yes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants