From 93ed61bf9bf3470af8f44c170c4ae41b8a57f466 Mon Sep 17 00:00:00 2001 From: Jiwei Guo Date: Wed, 29 Nov 2023 22:13:38 +0800 Subject: [PATCH] [fix][test] Fix flaky test SimpleProducerConsumerStatTest#testPartitionTopicStats (#21642) --- .../pulsar/client/api/SimpleProducerConsumerStatTest.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerStatTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerStatTest.java index b74e396cea526..5185a3b7e267c 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerStatTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerStatTest.java @@ -46,6 +46,7 @@ import org.awaitility.Awaitility; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.testng.Assert; import org.testng.annotations.AfterMethod; import org.testng.annotations.BeforeMethod; import org.testng.annotations.DataProvider; @@ -495,9 +496,10 @@ public void testPartitionTopicStats() throws Exception { msg = consumer.receive(5, TimeUnit.SECONDS); String receivedMessage = new String(msg.getData()); log.info("Received message: [{}]", receivedMessage); - String expectedMessage = "my-message-" + i; - testMessageOrderAndDuplicates(messageSet, receivedMessage, expectedMessage); + Assert.assertTrue(messageSet.add(receivedMessage), "Received duplicate message " + receivedMessage); } + Assert.assertEquals(messageSet.size(), numMessages); + // Acknowledge the consumption of all messages at once consumer.acknowledgeCumulative(msg);