Upgrade celery, Black #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcai122
commented
Apr 19, 2024
| model_name="venue", name="name", field=models.CharField(max_length=255, null=True), | ||
| model_name="venue", | ||
| name="name", | ||
| field=models.CharField(max_length=255, null=True), |
There was a problem hiding this comment.
new black splits into lines if we have trailing commas, otherwise tries to one line.
old black tried to one line and added trailing commas.
To make things look similar for most files where we had one line previously I deleted the trailing comma and reformatted but I ignored for migration files.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
=======================================
Coverage 90.66% 90.66%
=======================================
Files 61 61
Lines 2604 2604
=======================================
Hits 2361 2361
Misses 243 243 ☔ View full report in Codecov by Sentry. |
judtinzhang
approved these changes
Apr 20, 2024
backend/Pipfile
Outdated
| @@ -4,7 +4,7 @@ url = "https://pypi.org/simple" | |||
| verify_ssl = true | |||
|
|
|||
| [dev-packages] | |||
| black = "==19.10b0" | |||
| black = "*" | |||
There was a problem hiding this comment.
can we fix the black version here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade black to upgrade celery. Also got really annoyed by the dependency stuff depending on old click figured it was prolly time anyway.
Minimal changes to actual files (mostly migration file)
We can set up later something to ignore blame on this commit
https://www.stefanjudis.com/today-i-learned/how-to-exclude-commits-from-git-blame/