Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add profanity check for sublets #290

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

ashleyzhang01
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.24%. Comparing base (371c8e5) to head (ed29e4d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   89.23%   89.24%           
=======================================
  Files          60       60           
  Lines        2601     2612   +11     
=======================================
+ Hits         2321     2331   +10     
- Misses        280      281    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vcai122 vcai122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly just the pipfile comment, but looks pretty good otherwise! 0 shots

backend/sublet/serializers.py Outdated Show resolved Hide resolved
backend/Pipfile Show resolved Hide resolved
backend/sublet/serializers.py Outdated Show resolved Hide resolved
Copy link
Member

@judtinzhang judtinzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One quick question. Thanks ashley, 0 shots

backend/sublet/serializers.py Show resolved Hide resolved
Copy link
Contributor

@vcai122 vcai122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!!!!!!!!!!!

@ashleyzhang01 ashleyzhang01 merged commit ffc292f into master Apr 25, 2024
9 checks passed
@ashleyzhang01 ashleyzhang01 deleted the sublet-profanity-check branch April 25, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants