Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix college_house_events request #303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dr-Jess
Copy link
Contributor

@dr-Jess dr-Jess commented Aug 30, 2024

No description provided.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.51%. Comparing base (1e21aa9) to head (a4deb5b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   90.55%   90.51%   -0.04%     
==========================================
  Files          62       62              
  Lines        2658     2658              
==========================================
- Hits         2407     2406       -1     
- Misses        251      252       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ashleyzhang01 ashleyzhang01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason we need to disable SSL certificate verification? putting a little description in your PRs would be helpful in the future. otherwise looks good 👨‍💻

Copy link
Contributor

@tuneerroy tuneerroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to the code that explains why we're disabling the extra protection. +1 what Ashley said on the PR description (maybe add an example of a situation that we are now exposed to?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants