Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Me Groups #323

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Remove Me Groups #323

merged 1 commit into from
Nov 12, 2024

Conversation

vcai122
Copy link
Contributor

@vcai122 vcai122 commented Nov 11, 2024

We did a GSR refactor that removed the need for "Me" groups last year

  • "Me" groups existed in the first place so we could treat booking GSRs for users the same as booking GSRs for groups.
  • Turns out the logic can be optimized if we separate the use cases so we did just that in the GSR refactor, using group=None to just book the group for the given user.

This PR removes the the leftovers to erase the idea of "Me" groups completely from our codebase.

Also did a small refactor with a group membership view.

  • Note: I checked iOS code and users (now /mymemberships), membership, and groups isn't used at all
    • We probably will never implement group feature. But its probably worth refactoring this code so that it makes sense, eventually. Since if we are going to keep it, might as well avoid confusion and make the business logic clear. Right now it is pretty messy.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (f106b9b) to head (2d60616).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files          63       63           
  Lines        2661     2629   -32     
=======================================
- Hits         2417     2388   -29     
+ Misses        244      241    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vcai122 vcai122 requested a review from dr-Jess November 11, 2024 04:03
Copy link
Contributor

@tuneerroy tuneerroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! question: if we remove groups, how are we planning on supporting the Labs shared group?

@vcai122
Copy link
Contributor Author

vcai122 commented Nov 11, 2024

LGTM! question: if we remove groups, how are we planning on supporting the Labs shared group?

We aren't removing Groups. Groups are still alive and well. We are just removing the idea of "Me" groups as a singleton group, because we want to handle the logic of a single user booking with their own credits separately from group logic.

@tuneerroy
Copy link
Contributor

LGTM! question: if we remove groups, how are we planning on supporting the Labs shared group?

We aren't removing Groups. Groups are still alive and well. We are just removing the idea of "Me" groups as a singleton group, because we want to handle the logic of a single user booking with their own credits separately from group logic.

oh yeah i realized. I read that we planned to remove groups eventually but think i just misread that.

@vcai122 vcai122 merged commit 44965e9 into master Nov 12, 2024
9 checks passed
@vcai122 vcai122 deleted the remove-me-groups branch November 12, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants