Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add PGP Fix for New Email API #180

Merged
merged 3 commits into from
Sep 22, 2024
Merged

🐛 Add PGP Fix for New Email API #180

merged 3 commits into from
Sep 22, 2024

Conversation

joyliu-q
Copy link
Contributor

Patch Platform Dev by adding similar config to platform

Long term we should try to make the two extend from a base and not diverge (e.g. platform extend from platform dev and adds additional config).

@esinx esinx self-requested a review September 22, 2024 22:35
@@ -1,4 +1,4 @@
FROM pennlabs/django-base:b269ea1613686b1ac6370154debbb741b012de1a-3.9.14
FROM pennlabs/django-base:b269ea1613686b1ac6370154debbb741b012de1a-3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump image

@@ -0,0 +1,47 @@
import os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"staging" env makes more sense so I basically copied prod and removed cert envs


# Collect static files
RUN python3 /app/manage.py collectstatic --noinput
RUN python3 /app/manage.py collectstatic --noinput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on pennclubs btw

@esinx esinx merged commit adfedec into master Sep 22, 2024
7 checks passed
@esinx esinx deleted the joy/patch-platform-dev branch September 22, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants