Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pindexer: implement override for hardcoded values in app views #4936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cronokirby
Copy link
Contributor

Describe your changes

This adds two flags:

 --indexing-denom <INDEXING_DENOM>
            The denom to use for indexing related components, of the form passet1... [default:
            passet1w6e7fvgxsy6ccy3m8q0eqcuyw6mh3yzqu3uq9h58nu8m8mku359spvulf6

for setting the denom used for indexing (instead of USDC)

and

--dex-ex-min-liquidity <DEX_EX_MIN_LIQUIDITY>
            The minimum liquidity for the indexing denom in the dex explorer app view [default:
            100000000]

for overriding the minimum liquidity in terms of that asset for a pair to be considered in the aggregate dex explorer summary.

Closes #4920.

For testing, we can try running this against the testnet with different values.

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    indexing

@conorsch
Copy link
Contributor

Rebased on latest main (ad95d8c) to include #4934, to make testing this more straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pindexer: add override for indexing asset id
2 participants