Skip to content

Commit

Permalink
Add return_if_unmatched to ip enrich (#84)
Browse files Browse the repository at this point in the history
* add return_if_unmatched to ip enrich

* fix

* another fix

* again

* min version 3.8

* more version updates

* readme update

* add 3.11 test
  • Loading branch information
vvillait88 authored Aug 21, 2023
1 parent f06c55b commit 8ef82ae
Show file tree
Hide file tree
Showing 10 changed files with 122 additions and 225 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v3
with:
python-version: "3.7"
python-version: "3.8"
- name: Install Poetry
uses: snok/install-poetry@v1
- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v3
with:
python-version: "3.7"
python-version: "3.8"
- name: Install Poetry
uses: snok/install-poetry@v1
- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python-poetry.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11"]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ persistent=yes

# Minimum Python version to use for version dependent checks. Will default to
# the version used to run pylint.
py-version=3.7
py-version=3.8

# Discover python modules and packages in the file system subtree.
recursive=no
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
- [🏝 Sandbox Usage](#sandbox)
- [🌐 Endpoints](#endpoints)
- [📘 Documentation](#documentation)
- [Upgrading to v2.X.X](#upgrading-to-v2)


## 🔧 Installation <a name="installation"></a>

Expand Down Expand Up @@ -454,3 +456,7 @@ Conversely, this would be **invalid** because `fake_parameter` is not an input p
```python
PDLPY().person.identify({"fake_parameter": "anything"})
```
### Upgrading to v2.X.X <a name="upgrading-to-v2"></a>
NOTE: When upgrading to v2.X.X from vX.X.X and below, the minimum required python version is now 3.8.
324 changes: 107 additions & 217 deletions poetry.lock

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "peopledatalabs"
version = "1.2.0"
version = "2.0.0"
description = "Official Python client for the People Data Labs API"
homepage = "https://www.peopledatalabs.com"
repository = "https://github.com/peopledatalabs/peopledatalabs-python"
Expand Down Expand Up @@ -28,7 +28,7 @@ classifiers = [
"Source Code" = 'https://github.com/peopledatalabs/peopledatalabs-python'

[tool.poetry.dependencies]
python = "^3.7.2"
python = "^3.8"
email-validator = ">=1.1,<3.0"
pydantic = "^1.8"
python-dotenv = "^0"
Expand Down
2 changes: 1 addition & 1 deletion src/peopledatalabs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
from .main import PDLPY


__version__ = "1.2.0"
__version__ = "2.0.0"

__all__ = ["PDLPY"]
1 change: 1 addition & 0 deletions src/peopledatalabs/models/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,5 +122,6 @@ class IPModel(BaseModel):
return_ip_metadata: Optional[bool]
return_ip_location: Optional[bool]
return_person: Optional[bool]
return_if_unmatched: Optional[bool]
pretty: Optional[bool]
titlecase: Optional[bool]
2 changes: 1 addition & 1 deletion tests/client/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def test_version():
"""
Version check.
"""
assert __version__ == "1.2.0"
assert __version__ == "2.0.0"


@pytest.mark.usefixtures("fake_api_key")
Expand Down

0 comments on commit 8ef82ae

Please sign in to comment.